Front(fix): UI hot fixes [MARXAN-689] #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamontiaga
added
bug
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/ApCQ4ZFPu8Xv6sLX1Lvxhdegnek1 marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/BkXqCWEs5NweJv3pQtXZQBYdH5o1 |
anamontiaga
added
Ready to review
mbarrenechea
requested changes
Aug 25, 2021
| const mostDifSolutionsIsSelected = mostDifSolutions | ||
| && mostDifSolutionsData && mostDifSolutionsData.length > 0; | ||
| const noSolutionResults = (!solutionsAreFetching && !solutionsData.length) | ||
| || (!mostDifSolutionsisFetched && !mostDifSolutionsData.length); |
There was a problem hiding this comment.
Suggested change
| || (!mostDifSolutionsisFetched && !mostDifSolutionsData.length); | |
| || (mostDifSolutionsisFetched && !mostDifSolutionsData.length); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI hot fixes
Overview
Align Home
Change Carousel Home images
Change Blm chart images and set borders dinamically
Set back links on blue
Manage visibility on Solution sidebar
Delete double infoButton on features:
Solutions Table improvements: Add title and set info button on its right side
Solutions Table improvements: Colors: brighten blue and gray
Solutions Table improvements: refactor data fetching cases
Solutions Table improvements: remove text of info button and add scroll to the whole modal
Feature relevant tickets
MARXAN-689