Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front(feat):opacity manager [MARXAN-680][MARXAN-682] #461

Merged
merged 41 commits into from
Aug 19, 2021
Merged

Front(feat):opacity manager [MARXAN-680][MARXAN-682] #461

merged 41 commits into from
Aug 19, 2021

Conversation

anamontiaga
Copy link
Collaborator

@anamontiaga anamontiaga commented Aug 18, 2021 •
edited
Loading

Overview

Fixes

  • Recover best solution on detail

  • Frequency values not constants on solution details

  • Hovers on menu

  • Hide contributors + creators

  • Set BLM on scenario settings

Feat
  • Add opacity manager on legend

Feature relevant tickets

MARXAN-680

MARXAN-682

@anamontiaga
styles: menu hover
c9163a9
@anamontiaga
fix:comment contributors and creators on my porjects, project, publis…
82cc668 
…hed projects and publish p detail
@anamontiaga
fix: read frequency values from use legend
8216adb
@anamontiaga
fix: highlight best solution on detail
991a5ec
@anamontiaga
fix: remove description from legend
9a6547c
@anamontiaga
opacity manager: property on legend item and basic click tooltip
2d3de2b
@anamontiaga
opacity manager: property on legend item and basic click tooltip
73f5bcf
@anamontiaga
opacity manager: property on legend item and basic click ttip
cff3a52
@anamontiaga
opacity manager: slider
c1d3b96
@anamontiaga
opacity manager: add ui opacity manager to pa and frequency legend
9ca285d
@anamontiaga
opacity manager: onChangeOpacity
d52812b
@anamontiaga
opacity manager: save show map opacity on store
ba813a2
@anamontiaga
opacity manager: save edit map opacity on store
7730a88
@anamontiaga
opacity manager: improve naming on store actions
06f6dbd
@anamontiaga
opacity manager: set wdpa and frequency opacity on map
26ad066
@anamontiaga anamontiaga added Frontend Everything related frontend WIP Work in progress New feature New Feature labels Aug 18, 2021
@vercel
Copy link

vercel bot commented Aug 18, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/6PVjgMBwHh6x1C1TWcU8Nyd8ff3E
✅ Preview: https://marxan-git-feat-opacity-manager-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/FwL9w4d8VTygdyzL18SfHsLBDTW1
✅ Preview: https://marxan-storybook-git-feat-opacity-manager-vizzuality1.vercel.app

@anamontiaga anamontiaga changed the title Front(feat):opacity manager Front(feat):opacity manage r[MARXAN-680][MARXAN-682] Aug 18, 2021
@anamontiaga anamontiaga added the bug Something isn't working label Aug 18, 2021
@anamontiaga anamontiaga changed the title Front(feat):opacity manage r[MARXAN-680][MARXAN-682] Front(feat):opacity manager [MARXAN-680][MARXAN-682] Aug 18, 2021
mbarrenechea
mbarrenechea requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@mbarrenechea mbarrenechea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thee way you handling opacity is not going to be scalable

mbarrenechea
mbarrenechea requested changes Aug 19, 2021
View reviewed changes
app/components/map/legend/item/component.tsx Outdated Show resolved Hide resolved
app/components/map/legend/item/component.tsx Outdated Show resolved Hide resolved
app/hooks/map/index.ts Outdated Show resolved Hide resolved
app/hooks/map/index.ts Outdated Show resolved Hide resolved
app/hooks/map/index.ts Outdated Show resolved Hide resolved
app/layout/scenarios/show/map/component.tsx Outdated Show resolved Hide resolved
@anamontiaga anamontiaga merged commit 2ed7d71 into develop Aug 19, 2021
@tiagojsag tiagojsag deleted the feat/opacity-manager branch January 4, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarrenechea mbarrenechea mbarrenechea requested changes

Assignees
No one assigned
Labels
bug Something isn't working Frontend Everything related frontend New feature New Feature WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anamontiaga @mbarrenechea