MARXAN-545 - MARXAN-642 & MARXAN-652 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/6Q6gy7csuSdiFpK2htoEmYUveFSw marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/Ffb9CbAUikYuzwwtsXWyg2VfV8Ff |
3 tasks
kgajowy
changed the title
Dyostiq
approved these changes
Aug 9, 2021
Comment on lines
3
to
5
| export class FakeLogger implements LoggerService { | ||
| constructor(public readonly context?: string) {} | ||
|
|
There was a problem hiding this comment.
why is this context needed?
There was a problem hiding this comment.
Thanks, it indeed isn't needed 19df1e8
kgajowy
force-pushed
the
feat/MARXAN-545-application-pieces
branch
from
9f5166b
to
c40aebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incudes #416 & #415 & refactoring application structure, with minor fixes as well.