Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About page redesign #394

Merged
merged 4 commits into from
Aug 3, 2021
Merged

About page redesign #394

merged 4 commits into from
Aug 3, 2021

Conversation

pedrogpimenta
Copy link
Contributor

@pedrogpimenta pedrogpimenta commented Aug 3, 2021 •
edited
Loading

About page redesign

Overview

Redesign of the About page and its components

Designs

https://www.figma.com/file/cZR0Uqhm8pf3G0uAJjRxMN/Marxan-Visual_V02-Copy?node-id=5460%3A7455

Testing instructions

N/A

Feature relevant tickets

N/A

@pedrogpimenta pedrogpimenta added Frontend Everything related frontend WIP Work in progress labels Aug 3, 2021
@vercel
Copy link

vercel bot commented Aug 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/D47A1XBUZ6Fd1WLneMVpGyWxvTZe
✅ Preview: https://marxan-git-feat-about-page-redesign-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/4xhnCTkYMGUo6U7oUiThMtqhFo9w
✅ Preview: https://marxan-storybook-git-feat-about-page-redesign-vizzuality1.vercel.app

mbarrenechea
mbarrenechea requested changes Aug 3, 2021
View reviewed changes
app/layout/about/utilities/component.tsx Show resolved Hide resolved
app/layout/statics/column/component.tsx
src={image}
alt=""
style={{
width: '403px',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid of this magic numbers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too. I usually don't like it but I also don't see a good way to do it, a good way to add these images with the size the designers want. I could probably put some percentages, but I'm not sure this is a whole lot better... WDYT @mbarrenechea ?

app/layout/statics/hero/component.tsx Outdated Show resolved Hide resolved
app/layout/statics/hero/component.tsx Outdated Show resolved Hide resolved
@mbarrenechea mbarrenechea merged commit 3f9e5a2 into develop Aug 3, 2021
@mbarrenechea mbarrenechea deleted the feat/about-page-redesign branch August 3, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarrenechea mbarrenechea mbarrenechea approved these changes

Assignees
No one assigned
Labels
Frontend Everything related frontend WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrogpimenta @mbarrenechea