Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: order imports eslint configs #373

Merged
merged 5 commits into from
Jul 28, 2021
Merged

Conversation

anamontiaga
Copy link
Collaborator

Install eslint-plugin-import

Overview

Test to sort imports by path groups using an eslint plugin. We would need to align if this is the order we want and add all the dependencies

Testing instructions

  • The order is generated with the autosave.
  • It has not yet been implemented in the files. It will do it as we work on each file.

@anamontiaga anamontiaga added Frontend Everything related frontend WIP Work in progress labels Jul 26, 2021
@vercel
Copy link

vercel bot commented Jul 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/6WkdRuJvg9FeNUDUyJpkLpFTwAQh
✅ Preview: https://marxan-git-feat-order-imports-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/8XxdhWmER2ZFjdRmt1bUwFK7eVex
✅ Preview: https://marxan-storybook-git-feat-order-imports-vizzuality1.vercel.app

@anamontiaga
Copy link
Collaborator Author

This is how it fit on a file with many types of import. It is only a proposal:

sort imports

@anamontiaga anamontiaga added Ready to review PR ready to review and removed WIP Work in progress labels Jul 27, 2021
app/.eslintrc.js Outdated Show resolved Hide resolved
@anamontiaga
Copy link
Collaborator Author

Result after changes requested made:

order:imports fixes

Copy link
Member

@mbarrenechea mbarrenechea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it works

@mbarrenechea mbarrenechea merged commit 43105f5 into develop Jul 28, 2021
@mbarrenechea mbarrenechea deleted the feat/order-imports branch July 28, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Everything related frontend Ready to review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants