refactor: move scenario features data to shared lib #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/78tk2eGyvgyLjTcmuEgpSwLqPhSg marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/5TfsNczqHhHGscKRpZUPjq6Xfchq |
kgajowy
commented
Jul 22, 2021
Comment on lines
+18
to
+36
| async from( | ||
| outputDirectory: string, | ||
| scenarioId: string, | ||
| ): Promise<ScenarioFeatureData[]> { | ||
| const planningUnits = await this.scenarioFeatureData.findAndCount({ | ||
| where: { | ||
| scenarioId, | ||
| }, | ||
| select: ['id', 'featureId'], | ||
| }); | ||
| const _mapping = planningUnits[0].reduce<FeatureIdToScenarioFeatureData>( | ||
| (previousValue, sfd) => { | ||
| previousValue[sfd.featureId] = sfd.id; | ||
| return previousValue; | ||
| }, | ||
| {}, | ||
| ); | ||
| console.log(`--- scenario features data mapping`, _mapping); | ||
| return []; |
There was a problem hiding this comment.
Dummy placeholder for next PR
Dyostiq
approved these changes
Jul 22, 2021
| @@ -46,11 +48,21 @@ export class GeoOutputRepository { | |||
| const planningUnitsState: PlanningUnitsSelectionState = await this.planningUnitsStateCalculator.consume( | |||
| solutionsStream, | |||
| ); | |||
|
|
|||
| // TODO grab data from ScenarioFeaturesDataService | |||
| const _sfds = await this.scenarioFeaturesDataReader.from( | |||
There was a problem hiding this comment.
Suggested change
| const _sfds = await this.scenarioFeaturesDataReader.from( | |
| const _scenarioFeaturesDataStream = await this.scenarioFeaturesDataReader.from( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured out that adding more would be hard to read the diff, thus adding standalone PR for moving things around and setting really dummy shell/plan for putting the data to the db.