-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geoprocessing): report progress of the marxan run #341
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/6rnJV6tVpXBcaYUP3TvcVCWFEhCd marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/Ed1vGU31nG3GkEtE4jPhJXgfCGw2 |
this.previousChunk = current; | ||
for (const match of matches) { | ||
const [, currentRun, currentTotal] = match; | ||
this.outOf ??= +currentTotal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it should rather base on pre-defined number of desired runs (derived form input.dat
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for simplicity's sake we can even keep this as is - in practice (unless there's a bug in the Marxan CLI) the regex match should be equivalent to getting data from input.dat
, but I like the idea of this being self-contained as is now.
25880b3
to
1af6aa3
Compare
1af6aa3
to
36da3fd
Compare
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)