feat(marxan-runner): use output directory provided via input.dat #331
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/132SodPcwXQtDkn6Logdi5DTE5Ey marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/9TZeVHqTedazQjHQXTAirc6NDjkF |
kgajowy
force-pushed
the
feat/marxan-execution-output-directory
branch
from
442f6fc
to
432f31f
Compare
kgajowy
force-pushed
the
feat/marxan-execution-output-directory
branch
from
432f31f
to
2a492f9
Compare
|
Most likely it is about time to consider refactor of Workspace to contain all fetches/creations. |
| return fullPath as WorkingDirectory; | ||
| } | ||
|
|
||
| #hasPoisonNullByte = (path: string): boolean => path.indexOf('\0') !== -1; |
There was a problem hiding this comment.
what about escaping by ..?
| async () => this.workingDirectoryService.cleanup(workingDirectory), | ||
| async () => | ||
| this.workingDirectoryService.createOutputDirectory(workingDirectory), |
There was a problem hiding this comment.
why don't just pass an object here?
also, why isn't port abstract?
| async cleanup(directory: string): Promise<void> { | ||
| // TODO check if starts with tempDirectory | ||
| if (this.#hasPoisonNullByte(directory)) { | ||
| throw new Error(`Hacking is not allowed.`); | ||
| } |
There was a problem hiding this comment.
shouldn't we validate it on input, before cleaning up?
There was a problem hiding this comment.
@Dyostiq would you mind to elaborate? It is stateless, so you can pass any directory and it validates it on every use 🤔
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)