Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marxan-run): expose endpoints for starting/cancelling marxan execution #311

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

kgajowy
Copy link
Contributor

@kgajowy kgajowy commented Jul 5, 2021

Fundamentals for full process of running marxan

@vercel
Copy link

vercel bot commented Jul 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/F7Tv8CvujT1i3E6tD5maSap9k2r9
✅ Preview: https://marxan-git-feat-marxan-303-marxan-504-run-ca-22e523-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/6qQMSJMb8zSNpxY5UFWURKFDvFn8
✅ Preview: https://marxan-storybook-git-feat-marxan-303-marxan-23c1b8-vizzuality1.vercel.app

@@ -64,6 +65,9 @@ import { ProxyService } from '@marxan-api/modules/proxy/proxy.service';
const basePath = `${apiGlobalPrefixes.v1}/scenarios`;
const solutionsSubPath = `:id/marxan/run/:runId/solutions`;

const marxanRunTag = 'Marxan Run';
const marxanFilesTag = 'Marxan Run - Files';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

especially if we want to expand the use of @ApiTags() as we go + retrospectively, maybe this tag may be called marxanRunFilesTag (we'd have marxanFilesTags for the range of file upload operations we support, for example)

Comment on lines +16 to +22
await fixtures.GivenUserIsLoggedIn();
await fixtures.GivenProjectOrganizationExists();
await fixtures.GivenScenarioExists(`Mouse`);
await fixtures.GivenCostSurfaceTemplateFilled();
await fixtures.WhenMarxanExecutionIsRequested();
await fixtures.WhenMarxanExecutionIsCompleted();
await fixtures.ThenResultsAreAvailable();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this

@kgajowy kgajowy merged commit 8e1d9ca into develop Jul 7, 2021
@kgajowy kgajowy deleted the feat/MARXAN-303-MARXAN-504-run-cancel-endpoints branch July 7, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants