output entities migration ready + fake data for outputs #305
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/GgdUwb4cWFTCp9xjQ8V4LxbbzhFN marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/Cy5hdGiDDUMsmYishcozJbiJgDLV |
| ALTER TABLE scenario_features_data | ||
| DROP COLUMN target_met; | ||
| ALTER TABLE scenario_features_data | ||
| ADD COLUMN feature_id SERIAL; |
There was a problem hiding this comment.
should we make this also PRIMARY KEY for simplicity's sake?
Otherwise we should at least enforce uniqueness across (feature_id, scenario_id), I think
Also, I suggest to avoid calling this feature_id as we are already using these something_id names quite consistently for FKs (or sort of FKs if across dbs) - maybe something like marxan_featureid?
api/apps/geoprocessing/src/migrations/geoprocessing/1624890503611-marxanOutputEntities.ts
Show resolved
Hide resolved
| ADD COLUMN run_id int; | ||
|
|
||
| ALTER TABLE output_scenarios_pu_data | ||
| ADD CONSTRAINT value_out_chk CHECK (value = 0 or value = 1); |
There was a problem hiding this comment.
do we still need value to be double precision if we constrain it to 0 or 1?
Co-authored-by: andrea rota <[email protected]>
kgajowy
force-pushed
the
chore/api/output-entities-definition
branch
from
f71e729
to
34c7491
Compare
… till solution is found
Migration + fake data for outputs