test(api): scenario-features: pre-gap data formatting & enable spec #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/A8pxg619xtC32rmKbLaivjVn5JMc marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/6tzUNrwC8iedGiTfYACzHDyWP8vv |
Dyostiq
approved these changes
Jun 10, 2021
| @@ -127,10 +127,10 @@ export class ScenarioFeaturesService extends AppBaseService< | |||
| ...base, | |||
| onTarget: metArea >= totalArea * targetPct, | |||
| met: +((metArea / totalArea) * 100).toFixed(2), | |||
| metArea, | |||
| metArea: +metArea.toFixed(2), | |||
There was a problem hiding this comment.
not sure how accurate rounding we need, but keep in mind that
1.55.toFixed(1) // 1.6
1.555.toFixed(2) // 1.55
hotzevzl
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)