-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/api/marxan 333 vl migrate from proxy controller #256
Feature/api/marxan 333 vl migrate from proxy controller #256
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/CJk3WJF42mJd8WWAzrUw2tscEPJB marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/Cb2jCXgLBegY52ZhJ71QUsdvkxUx |
…til function to convert from nominatim to bbox
3669193
to
300e81b
Compare
I'd rather have a command to generate swagger.json on demand from the app instead of checking the entire swagger.json in the repo, it's a generated artifact of the code that may get out of sync |
api/apps/api/src/modules/planning-units/planning-units.controller.ts
Outdated
Show resolved
Hide resolved
api/apps/geoprocessing/src/modules/planning-units/planning-units.service.ts
Outdated
Show resolved
Hide resolved
api/apps/geoprocessing/src/modules/planning-units/planning-units.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aagm thanks! with the caveat that I could give this PR only a very quick look and that I didn't run it locally, it overall makes sense to me and I'd be happy for this to be merged to unblock frontend work, and we can then revisit any quirk, if any. Have a look at my inline comments and decide what to do - most are minor anyway.
Overview
Testing instructions
make start-api
and inside test, in geoprocessing there is anindex.html
file that will allow you to test the vector layersThere is one thing that I will want to finish in another pr that is the capability of testing that the mbtile response JSON has produced the response required. But as I said this is for a future pr
Many other things probably can be improved with the wisdom of @hotzevzl, @kgajowy, @alexeh and @Dyostiq but if possible can we leave them for a new pr?
Feature relevant tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)