Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): projects: verify admin regions and assign bbox #234

Merged
merged 8 commits into from
Jun 8, 2021
Merged

feat(api): projects: verify admin regions and assign bbox #234

merged 8 commits into from
Jun 8, 2021

Conversation

kgajowy
Copy link
Contributor

@kgajowy kgajowy commented Jun 2, 2021 •
edited
Loading

  • convert pu- jobs to use QueueModule to be able to intercept job submission
  • remove redundant/invalid tests/params from json-api specs
  • refactor project specs for brevity
  • refactor protected-areas-jobs-triggering-for-admin-areas specs for brevity (previously copied from projects)
  • fix/refactor protected-areas specs

@vercel
Copy link

vercel bot commented Jun 2, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/4EV84tKamTXync5Z6UfLby8FySRE
✅ Preview: https://marxan-git-api-marxan-447-project-cu-bbox-shell-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/8xxG2hFqphQA36AKhmuy1CASTyrf
✅ Preview: https://marxan-storybo-git-api-marxan-447-project-cu-bbox-shell-26326f.vercel.app

@kgajowy kgajowy force-pushed the api/MARXAN-447-project-cu-bbox-shell branch from 6f546fa to 3471d06 Compare June 7, 2021 06:02
@kgajowy
Copy link
Contributor Author

kgajowy commented Jun 7, 2021

@hotzevzl as per discussion, skipping tests interfering with project creation side effects (they could be refactored tho in future)

Base automatically changed from api/MARXAN-447-project-cu-bbox to develop June 7, 2021 06:32
@kgajowy kgajowy force-pushed the api/MARXAN-447-project-cu-bbox-shell branch from a87636b to 1bf132c Compare June 7, 2021 08:12
@kgajowy kgajowy marked this pull request as ready for review June 7, 2021 08:26
@kgajowy kgajowy requested review from hotzevzl and aagm June 7, 2021 08:26
@kgajowy kgajowy requested a review from hotzevzl June 7, 2021 12:01
@hotzevzl
Copy link
Member

hotzevzl commented Jun 8, 2021

@kgajowy I'd merge this as is if you are happy with it, and add refactoring of specs missing from your todo list for this PR in a separate small PR- feel free to merge

@kgajowy kgajowy merged commit 73faed9 into develop Jun 8, 2021
@kgajowy kgajowy deleted the api/MARXAN-447-project-cu-bbox-shell branch June 8, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzevzl hotzevzl hotzevzl approved these changes

@aagm aagm Awaiting requested review from aagm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgajowy @hotzevzl