Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(geoprocessing): cost-surface: integration test #230

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

kgajowy
Copy link
Contributor

@kgajowy kgajowy commented Jun 1, 2021

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/Ar8z5kpHmXqLWjgLCGsdvGPoeaJh
✅ Preview: https://marxan-git-geoprocessing-marxan-445-cost-surface-6f51ac.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/6t1jHXwABQMYukbAmpjX7hvdrq3q
✅ Preview: https://marxan-storybo-git-geoprocessing-marxan-445-cost-surface-e03710.vercel.app

import { GeoJSON } from 'geojson';
import { ShapefileService } from '../../shapefiles/shapefiles.service';

import { CostSurfaceJobInput } from '../cost-surface-job-input';
import { ShapefileConverterPort } from '../ports/shapefile-converter/shapefile-converter.port';

@Injectable()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-injectable seems to not receive dependencies through Nest's DI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the decorator, TS does not emit design:paramtypes, thus Nest's DI is not able to get those types

@kgajowy kgajowy merged commit 0eef2d4 into develop Jun 2, 2021
@kgajowy kgajowy deleted the geoprocessing/MARXAN-445-cost-surface-test branch June 2, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants