-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): transform project to monorepo #208
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/3cA4ZjHoodBwHWyASvRdFjCcxDnT marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/2w7Jct7mYtrjVZWKnfbDJ9qR7PYT |
07f0af5
to
7e6c4ba
Compare
7e6c4ba
to
d6a463e
Compare
I'll omit the test commit during the rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dyostiq thank you! almost everything that I could check so far seems ok:
- build from clean-slate
- migrations
- seed-dbs
- unit tests
- e2e tests
Given that such a far-reaching reorganization can be hard to keep up to date for long as we keep merging other PRs, I would be keen to merge this sooner rather than later if nobody has strong concerns.
Given that "stuff seems to work", and especially that tests keep passing, I think that it should be easier to deal with any snags as they emerge, if at all, rather than trying to unearth any snags before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dyostiq thanks, this is awesome 🚀
All works ok from my point of view, I'd be keen to merge after confirming with the team tomorrow morning first thing that everyone is ok with rebasing their open PRs and adjusting paths 😱
We may want to revisit the Dockerfiles in a second moment to avoid copying into the container images source we may not need, but we'd need to do some work there in any case for production images, so I would not worry about this now.
09027d2
to
e1f13d2
Compare
e1f13d2
to
e23a0c4
Compare
e23a0c4
to
ae1e93f
Compare
ae1e93f
to
7bbbe1a
Compare
7bbbe1a
to
8596b50
Compare
8596b50
to
6989328
Compare
@hotzevzl |
yep, that's the plan as we move towards proper staging and eventually prod deployments - I'll likely do a multi-stage Docker image build |
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)