feat(api): cost-surface: application logic #196
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/6TXFkn5dByLcDBL8gYiodK8zR8sc marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/CuMFwmWfwvTqQmRZic5toUbCLvjy |
kgajowy
force-pushed
the
feat/MARXAN-413-cost-surface-application
branch
from
1da4309
to
cf20031
Compare
api/src/modules/scenarios/cost-surface/__mocks__/cost-surface-events-fake.ts
Show resolved
Hide resolved
| import { CostSurfaceInputDto } from '../../analysis/entry-points/adjust-cost-surface-input'; | ||
|
|
||
| export abstract class ResolvePuWithCost { | ||
| abstract fromShapefile( |
There was a problem hiding this comment.
Which is the purpose of this class?
Are we introducing Hex. approach?
There was a problem hiding this comment.
Its just an interface what main logic will use.
There was a problem hiding this comment.
Dependency Inversion Principle
|
|
||
| @Injectable() | ||
| export class CostSurfaceFacade { | ||
| constructor( | ||
| private readonly adjustCostSurfaceService: AdjustCostSurface, | ||
| private readonly proxyService: ProxyService, | ||
| private readonly shapefileConverter: ResolvePuWithCost, |
There was a problem hiding this comment.
ResolvePuWithCost is instantiated as shapefileConverter? Naming is confusing for me
Can you give further explanation?
There was a problem hiding this comment.
@kgajowy Sorry, I forgot to click 'Start review...'
There was a problem hiding this comment.
@alexeh its input is a shapefile and returns base PU ids with cost. Suitable names are always appreciated ;)
kgajowy
force-pushed
the
feat/MARXAN-413-cost-surface-application
branch
from
9605002
to
35fcfd9
Compare
Cost Surface update - application logic
Overview
Part of
Users should be able to upload shapefiles of scenario cost surfaces- subtask https://vizzuality.atlassian.net/browse/MARXAN-413Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)