Refactior File Service #192
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/HmdGb3o1rk25WqnSx58z2srY4u5h marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/7eZCqfb3vtgPbdTZznUHU1tL4eMf |
Await for FS ops Delete FileService logger context set (PU Controllers will handle) Catch error for deleteDataFromFs in ShapefileService
Add logger for error catching in file deletion
alexeh
added
Ready to review
There was a problem hiding this comment.
The conversion of shp to geojson works as a charm, even for medium sized shapefiles, congratulations!.
Said this; I'm seeing a lot of problems with invalid shapefiles. For some reason is not taking into account missing files like .proj which leads to an erroneous projection output.
is not validating file upload sizes, and geojson allowed types or correctness of geometry (yet right?).
very large shapefiles causes Unexpected exception on proxy for shapefile upload service - Error: socket hang up
Refactior File Service
This PR introduces a refactor to create stand-alone File Service.
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)