-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature bulking: added edition modes [MRXNM-58] #1690
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@hotzevzl I think the solution (and the pic) are quite self-explanatory, but let me know if something comes up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andresgnlez thank you - I like your solution, clear and simple (at least to understand and use, not sure about the implementation itself 😬 but that was on you, in any case 😅).
I think this solves nicely the UX limitations that users were reporting, from the original design.
One small thing - while trying to punch in some random values when using this feature branch, I run into a small glitch (probably unrelated, maybe it's been there all along and we never noticed nor did users): for specific values (so far, I've been able to trigger it by setting target to 55% specifically, I couldn't figure out other such values), I think that the value gets mangled before being sent to the API, setting it to 55.00000000000001
🤔
The screenshots below show what I see (this is Firefox 129.0 on Arch Linux, in case it's browser-related) after saving a bulk edit with target set by myself to 55
, once I see the feature list again:
And once I reopen the bulk edit modal (while selecting only one feature, of course - if I select more than one I get the default 50
and 1
values respectively):
also in terms of UX here - maybe when bulk editing with > 1 feature selected, rather than showing some default values (50% and 1 respectively for target and fpf), should we leave the inputs blank? Really minor, and I don't think this will ever be a real cause of confusion for users (such as "whoops, I set all the targets to 50%, I didn't really want to do that, I just forgot to edit that value"), and it's also something that - if ever happens - is easy to recover from, by bulk editing again the relevant features, so I'm ok with us leaving things as they are (and have always been, IIRC) in terms of these defaults when the bulk edit modal is brought up. |
and another small thing - at last in FF 129, if I bulk select all features by toggling the check box above the features, then edit the features and save the edits, once the processing finishes, I am back to the list of features, with none of the features selected, but the "select all" check box selected - again, super minor and I'd try to avoid cramming more things into this PR, but in case it's something really easy to change and regression-proof, please consider if it's worth changing: |
…l fields are populated.
Substitute this line for a meaningful title for your changes
Overview
This PR solves the casuistic of an user being able to perform unwanted changes when performing certain bulking actions.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)