Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRXN23-624] targets: sync local with remotes changes in targets #1681

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

andresgnlez
Copy link
Member

Substitute this line for a meaningful title for your changes

Overview

This PR removes a side effect triggered when the user searched for some targets and the edited values were reverted to app's defaults after rendering the filtered results.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

https://vizzuality.atlassian.net/browse/MRXN23-624


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@andresgnlez andresgnlez added the Frontend Everything related frontend label Apr 18, 2024
@andresgnlez andresgnlez self-assigned this Apr 18, 2024
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:03am

@hotzevzl
Copy link
Member

@andresgnlez thanks! this now works for me as expected.

going to merge this...

@hotzevzl hotzevzl merged commit 5754ad8 into develop Apr 24, 2024
13 checks passed
@hotzevzl hotzevzl deleted the MRXN23-624-fe-targets-not-saving-when branch April 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Everything related frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants