delete dangling feature_amounts_per_planning_unit data straight away when deleting a feature [MRXN23-518] #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hotzevzl
force-pushed
the
chore/api/MRXN23-518_remove-dangling-feature-amounts-per-pu-when-deleting-a-feature
branch
from
20f205c
to
df58c8d
Compare
hotzevzl
force-pushed
the
chore/api/MRXN23-518_remove-dangling-feature-amounts-per-pu-when-deleting-a-feature
branch
from
287fd89
to
c8e9c1a
Compare
hotzevzl
force-pushed
the
chore/api/MRXN23-518_remove-dangling-feature-amounts-per-pu-when-deleting-a-feature
branch
from
c8e9c1a
to
413bf67
Compare
|
allright, I think this is ready at last - so much for "just adding a small test", when needing to avoid considering the new async upload once ready 😅 while tests run in this fork:
|
…when deleting a feature This is a fast operation, so it can be done straight away. Other more expensive db deletions are still left to the garbage collector.
hotzevzl
force-pushed
the
chore/api/MRXN23-518_remove-dangling-feature-amounts-per-pu-when-deleting-a-feature
branch
from
413bf67
to
17ee3ea
Compare
KevSanchez
approved these changes
Feb 19, 2024
KevSanchez
deleted the
chore/api/MRXN23-518_remove-dangling-feature-amounts-per-pu-when-deleting-a-feature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements the original fix to MRXN23-518, adding deletion of dangling
feature_amounts_per_planning_unitrows while deleting a feature.https://vizzuality.atlassian.net/browse/MRXN23-518
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)