MARXAN-1643-modify-signup-to-include-bakground #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hotzevzl
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
My spider sense (https://en.wikipedia.org/wiki/Macrothele_calpeiana#/media/File:Macrothele_calpeiana.JPG) makes me lean on "just stuffing stuff into a JSONB document" kind of approach for this stuff (we should be ok given that we're wrapping things up, but these closed lists often escalate quickly to need to include "other" and then some free user input for "other"... and so on).
So, I guess we can merge as is, in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Adds two new columns and enums for
userscolumns.-Adapts sign-up endpoint to allow sending
backgroundandlevelinformation.