-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forbid changes to legacy project imports [MARXAN-1612] #1136
forbid changes to legacy project imports [MARXAN-1612] #1136
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @hotzevzl ! The only thing left that i would like to review about this PR is about using this guard when creating a scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @angelhigueraacid - all good, except for some naming that in my opinion could be improved for clarity.
...project-import/domain/legacy-project-import-checker/legacy-project-import-checker.service.ts
Outdated
Show resolved
Hide resolved
.../modules/legacy-project-import/application/mark-legacy-project-import-as-finished.handler.ts
Show resolved
Hide resolved
...ct-import/domain/legacy-project-import-checker/legacy-project-import-checker.service.spec.ts
Outdated
Show resolved
Hide resolved
api/apps/api/src/modules/projects/block-guard/marxan-block-guard.service.spec.ts
Outdated
Show resolved
Hide resolved
api/apps/api/src/modules/projects/block-guard/marxan-block-guard.service.spec.ts
Outdated
Show resolved
Hide resolved
0897ca1
to
43ae60f
Compare
This PR adds:
LegacyProjectImportChecker
service. Now block guard checks if a project is blocked depending if there is an ongoing legacy project import for the given project.Feature relevant tickets
Block legacy projects being imported