Public-Projects-ExportId-Switch #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rubvalave
force-pushed
the
feat/exportId-public-projects-switch
branch
from
b8ffb41
to
fdc376d
Compare
aciddaute
reviewed
May 5, 2022
api/apps/api/src/modules/published-project/published-project-crud.service.ts
Outdated
Show resolved
Hide resolved
api/apps/api/src/modules/published-project/published-project.service.ts
Outdated
Show resolved
Hide resolved
hotzevzl
reviewed
May 5, 2022
rubvalave
force-pushed
the
feat/exportId-public-projects-switch
branch
from
fdc376d
to
f38c8d5
Compare
rubvalave
force-pushed
the
feat/exportId-public-projects-switch
branch
from
f38c8d5
to
fb485f4
Compare
aciddaute
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add conditions on findAll/findOne methods in public projects to avoid showing exportId when it is not ready.
-Add specific test to check that exportId is shown if export is finished.