MARXAN-1274-publicMap-screenshot #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hotzevzl
approved these changes
Apr 26, 2022
| @@ -5,6 +5,7 @@ import { | |||
| Creator, | |||
| Resource, | |||
| } from '../dto/create-published-project.dto'; | |||
| import { string } from 'fp-ts'; | |||
There was a problem hiding this comment.
I don't think this is what you meant (though it may be what LSP and vscode thought you meant)
| import { WebshotService } from '@marxan/webshot'; | ||
| import { AppConfig } from '@marxan-api/utils/config.utils'; | ||
| import { assertDefined } from '@marxan/utils'; | ||
| import { isLeft, isRight } from 'fp-ts/lib/These'; |
There was a problem hiding this comment.
Suggested change
| import { isLeft, isRight } from 'fp-ts/lib/These'; | |
| import { isLeft, isRight } from 'fp-ts/lib/Either'; |
api/apps/api/src/modules/published-project/published-project.service.ts
Outdated
Show resolved
Hide resolved
| company: { name: 'logo', logoDataUrl: blmImageMock }, | ||
| creators: [{ displayName: 'fake name', avatarDataUrl: blmImageMock }], | ||
| resources: [{ title: 'fake url', url: 'http://www.example.com' }], | ||
| config: { baseUrl: 'example/png', cookie: 'randomCookie' }, | ||
| scenarioId, |
There was a problem hiding this comment.
in hindsight, I think we should have labelled this featuredScenarioId in the DTO for this, but let's not get there now 😓
There was a problem hiding this comment.
In fact, I think I would change it as you suggested, mainly because once I start the export here, I would also be able to select which scenarios I want for the export and it can get confusing real fast.
rubvalave
force-pushed
the
MARXAN-1274-add-publishedProject-map-generation
branch
from
9fb3d33
to
2aaa8ce
Compare
rubvalave
force-pushed
the
MARXAN-1274-add-publishedProject-map-generation
branch
from
2aaa8ce
to
12ed10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Adds screenshot generation to publish action.
-Adds new location field to published project entity.
-Adapts tests to new fields.
-Minor removal of redundant fixture data.