add api config items to geoprocessing service [MARXAN-1490] #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hack to allow the geoprocessing service to start again in k8s environments. Recent changes (which I could not identify with certainty) started causing more parts of the API code to be transpiled when Docker images for k8s deployments are built, and included in the built `dist` folder. This would in turn lead to some of the API's own config items to be looked up when starting up the geoprocessing service (unsuccessfully, since they are not available in the config setup for the geoprocessing service). TL;DR we may have had a few direct dependencies between libs and api or geoprocessing and api for a while and never noticed since everything (both services and all the libs) is built and shipped in Docker images run via Compose, but once the builds started including in the geoprocessing service intertwined API code that references config items, the stricter separation of environments in k8s led to failure to start the geoprocessing service. This commit temporarily works around this issue by exposing all the API config items in the geoprocessing service, and providing the same defaults for these that would be used in the api service. The proper solution is of course to undo these dependencies and then undo all the changes in this commit. Since this will not be straightforward though, in the meanwhile the hack in this commit should allow the geoprocessing service to at least start again.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hotzevzl
deleted the
hack/geoprocessing/MARXAN-1490_add-spurious-config-settings-from-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial workaround (only) for https://vizzuality.atlassian.net/browse/MARXAN-1491