Skip to content

Commit

Permalink
remove incorrect quoting of variable value
Browse files Browse the repository at this point in the history
This being make, the original implementation caused the value of the
make variable COMPOSE_PROJECT_NAME to _include the surrounding
double-quotes_, and this _happened_ to work just because we were using
this variable in shell commands, where the quoting would be handled as
normal CLI quoting of a string. However, since we _also_ make this make
variable available as environment variable (through the `export` command
through which we set env vars from a dotenv file), this ended up
breaking things from Compose v2.4 through this change:
docker/compose#9332.
  • Loading branch information
hotzevzl committed May 6, 2022
1 parent 8f19afb commit 839f2a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ DOCKER_CLEAN_VOLUMES := $(if $(environment), , \
docker volume rm -f marxan-cloud_marxan-cloud-postgresql-api-data && \
docker volume rm -f marxan-cloud_marxan-cloud-postgresql-geo-data && \
docker volume rm -f marxan-cloud_marxan-cloud-redis-api-data )
COMPOSE_PROJECT_NAME := "marxan-cloud"
COMPOSE_PROJECT_NAME := marxan-cloud

## some color to give live to the outputs
RED :=\033[1;32m
Expand Down

0 comments on commit 839f2a5

Please sign in to comment.