update tests to match updated implementation

Vizzuality · Aug 4, 2023 · 0c505a4 · 0c505a4
1 parent 56043c0
commit 0c505a4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/api/apps/api/test/upload-feature/upload-feature.e2e-spec.ts b/api/apps/api/test/upload-feature/upload-feature.e2e-spec.ts
@@ -63,7 +63,7 @@ test(`if tagging info is included in DTO and valid, created feature should be ta
   );
 
   // ASSERT
-  await fixtures.ThenGeoFeaturesAreCreated(result, name, description);
+  await fixtures.ThenGeoFeaturesAreCreated(result, name, description, tag);
   await fixtures.ThenGeoFeatureTagIsCreated(name, tag);
 });
 
@@ -86,7 +86,7 @@ test(`if there is already an existing feature with a tag that has equivalent cap
   );
 
   // ASSERT
-  await fixtures.ThenGeoFeaturesAreCreated(result, name, description);
+  await fixtures.ThenGeoFeaturesAreCreated(result, name, description, equivalentTag);
   await fixtures.ThenGeoFeatureTagIsCreated(name, equivalentTag);
   // TODO Check for update of last_modified_at for all affected tag rows for project when implemented
 });
diff --git a/api/apps/api/test/upload-feature/upload-feature.fixtures.ts b/api/apps/api/test/upload-feature/upload-feature.fixtures.ts
@@ -205,10 +205,14 @@ export const getFixtures = async () => {
       result: request.Response,
       name: string,
       description: string,
+      tag?: string,
     ) => {
-      expect(result.body).toEqual({
-        success: true,
-      });
+      // Check response payload, in JSON:API format
+      expect(result.body?.data?.type).toEqual('geo_features');
+      expect(result.body?.attributes?.isCustom).toEqual(true);
+      expect(result.body?.attributes?.featureClassName).toEqual(name);
+      expect(result.body?.attributes?.tag).toEqual(tag);
+
       const features = await geoFeaturesApiRepo.find({
         where: {
           projectId,