Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components cleanup #137

Merged
merged 40 commits into from
Aug 4, 2023
Merged

components cleanup #137

merged 40 commits into from
Aug 4, 2023

Conversation

mbarrenechea
Copy link
Member

@mbarrenechea mbarrenechea commented Mar 13, 2023

  • Removed most components
  • Removed storybook
  • Added MDX documentation of the remaining components (map, legend, icon)
  • Removed layer-manager and use a custom simple layer-manager on the map implementation instead
  • add instructions noting shadcn components should be used whenever possible.
  • Install Shadcn and use Button component
  • update docs deployment in Vercel from Storybook's to serve '/docs'
  • use use-hooks-ts instead of use-debounce package: Is typescript friendly, treeshakeable, with a good amount of stars and good documentation and offers a variety of hooks more than just the use-debounce
  • Fix all typing warnings

NEXT:

  • Move to Next 13
  • Remove Carousel?
  • Merge with the map scaffold

NEXT ISSUES:

Closes #123

@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
front-end-scaffold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 1:43pm

@Bluesmile82
Copy link
Contributor

I'm updating the PR to recover carousel, cookies, loading and search as they don't exist on shadcn

@Bluesmile82 Bluesmile82 added the work-in-progress work in progress label Jun 9, 2023
@andresgnlez andresgnlez marked this pull request as draft June 9, 2023 12:00
@davidsingal davidsingal merged commit ba91d96 into main Aug 4, 2023
@davidsingal davidsingal deleted the v1 branch August 4, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacement of native UI components with RadixUI
5 participants