Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15 Provide tagged string template functions #21

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

phuvinhbmt
Copy link
Contributor

@phuvinhbmt phuvinhbmt commented Dec 29, 2023

Resolves #15

@phuvinhbmt phuvinhbmt requested a review from VitorLuizC January 3, 2024 12:54
@phuvinhbmt
Copy link
Contributor Author

@VitorLuizC I updated normalizeWhiteSpaces per your comment. Let me know if it needs updating anything. Thanks

@phuvinhbmt
Copy link
Contributor Author

@VitorLuizC do you mind having a look at this pr when you have time please ? Cheers

Copy link
Owner

@VitorLuizC VitorLuizC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VitorLuizC VitorLuizC merged commit 2eab0d4 into VitorLuizC:master Feb 13, 2024
@VitorLuizC
Copy link
Owner

@phuvinhbmt sorry to take so long, I really have to improve my priorization skills in order to be a good maintainer again. Anyway, your PR was merged, and it was published under version 2.5.0.

Thank you a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide tagged string template functions
2 participants