Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spatial shift for bboxes 2d #357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Aurelien-VB
Copy link
Contributor

All actual changes are in the _spatial_shift function, everything else comes from the line wrapping which doesn't appear to be at the same format.

The issue was coming from the xcyc format and then clamp that would move the center and thus keep boxes that are outside the image.
Instead I just use the xyxy format making it work directly.

I'm not sure I understand why we did a min with ones before, I replaced everything with the clamp.

@Aurelien-VB Aurelien-VB self-assigned this Jun 23, 2023
@Aurelien-VB Aurelien-VB requested a review from thibo73800 June 23, 2023 15:12
@Aurelien-VB
Copy link
Contributor Author

I also added a fix to frame spatial shift because when the shift was negative there was pixels at the border not being masked out.

@Aurelien-VB Aurelien-VB added the aloscene aloscene label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aloscene aloscene
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant