Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt issue #64

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Prompt issue #64

merged 5 commits into from
Jun 19, 2024

Conversation

lahirulhr
Copy link
Member

#47 Fixed!

@lahirulhr lahirulhr self-assigned this Jun 19, 2024
@lahirulhr lahirulhr merged commit 3c4fec0 into nova4support Jun 19, 2024
@lahirulhr lahirulhr deleted the prompt_issue branch June 19, 2024 07:19
$timeout = config('nova-two-factor.reauthorize_timeout', 5);

return session()->get('2fa.prompt_at', now()->subMinutes($timeout + 5));
Session::put('2fa.prompt_at', now());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is never called

Copy link
Member Author

@lahirulhr lahirulhr Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Conflict resolution went wrong. line 74 should be removed. will fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants