-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in browser rendering attached example #99
Comments
Here is an updated example file. Still get the same browser error. |
I've linked a diagram that shows how I would visualize the attached example. The diagram includes a key that identifies which SO and SBO terms decorate the ComponentDefintions, Participations, and Interactions that make up the example. https://docs.google.com/presentation/d/15XRxOs1CL1YcMgvKRI7GSsHZPBUAEU621w0YGG9T3SY/edit?usp=sharing |
Hi Nic, In this screenshot, I think you're saying r2, r10, r7 together create the r7 gRNA (total 4 participants). Are r2 and r10 suppose to be DNA parts like promoter or rbs? The visualizations that we have been creating only have up to 3 participants (usually 2). An activation like the screenshot above would only have a link between the r7 gRNA gene -> r7 gRNA. |
Hi Nic, I rebuilt your example (see attached ZIP), and I fixed a number of issues and got the VisBol rendering shown below. Here are some of the issues I fixed:
Here are the issues that remain:
|
@cjmyers As for putting the CDs in the box, do you want the nonDNA participants to be left aligned or do you want it to point to the center of dotted box? both is bossible. I think for this version, Considering the fact that we always have one non-DNA on top of CD, it would visually be better to have center alignment. |
If there is just one interaction, then center alignment does look the best. However, if you consider your example of the "r7 gRNA gene", there are multiple interactions that involve the DNA component. Ideally, these interactions would be combined. In this case, the interactions should be ordered where the inhibition or stimulation interactions come first, then the production interaction(s). The set of interactions would then be centered on top. |
This looks much improved to me. The objects rendered in the interactions do not need to be also rendered as separate components at the top, though anything not rendered in an interaction should be. Also, for r2 gRNA, the text could be lower so it does not run over the arrow. |
Should move RNA gene label lower and avoid it overlapping arrow. |
TypeError: undefined is not an object (evaluating 'interaction.participants[i].segment.role = null')
yeast_gates_network_example.zip
The text was updated successfully, but these errors were encountered: