Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten interactions #85

Open
dany-fu opened this issue Jul 25, 2018 · 3 comments
Open

Flatten interactions #85

dany-fu opened this issue Jul 25, 2018 · 3 comments

Comments

@dany-fu
Copy link
Contributor

dany-fu commented Jul 25, 2018

Don't render duplicate components individually (see mapsTo within Modules and FunctionalComponents)

@cjmyers
Copy link
Collaborator

cjmyers commented Oct 29, 2018

This is an example file with MapsTos to indicate how interactions should be connected.

v2_circuit_0x78_2_A1_AmtR_module.zip

@asadeg02
Copy link
Member

@cjmyers Below is the rendering after merging the interactions, I have also merged degradations to be shown as part of circuit interactions. This way only interactions of type non-covelant-binding are rendered separately. right now it's kind of hard to merge them since proteins don't have any more space for any other interaction arrows. please let me know your thoughts on this!

combined

@cjmyers
Copy link
Collaborator

cjmyers commented Dec 12, 2018

@asadeg02 these look very good. A couple small issues:

  1. Let's put the inhibitions and stimulations to the left of the productions.
  2. The stimulation arrow in the second figure is directed in the wrong direction.
  3. As for non-covalent binding, you could put one reactant to the left and one above. For example, for Ara_AraC_protein, you could have protein, AraC_protein, to the left and the small molecule Ara above. Alternatively, we could have the degradations all go above, which gives you more room in the horizontal direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants