Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bitmap range overflow result in incorrect label layout #38

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

xiaoluoHe
Copy link
Contributor

@xiaoluoHe xiaoluoHe commented Jun 14, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. when setRange to bitmap array, we should mark sure the range is not outside of boundaries, or it will make some mistake, like occupying the start of next few lines;
  2. currently the final position of a text will be the last candidate position. if configured hideOnHit, the no-space text will not be placed to original position;
  3. Conclusion for clampForce, we decide not to do auto-clampIn but we will check if the text is out of boundary,

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@neuqzxy neuqzxy merged commit 8a7a738 into main Jun 14, 2023
@neuqzxy neuqzxy deleted the fix/label-overlap-optimize branch June 14, 2023 12:10
xile611 pushed a commit that referenced this pull request Jul 6, 2023
fix: bitmap range overflow result in incorrect label layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants