Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/label component ignore text buf #35

Conversation

xiaoluoHe
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. As text bound calculation will add 2 pixel buffer which is not necessary in label overlapping, one way to avoid the buf is to configureboundsPadding to a negative value;

  2. fix boundsPadding attribute is not work in text graphic.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@neuqzxy neuqzxy merged commit d33c4d0 into feat/circular-dependency-zhouxinyu Jun 13, 2023
@neuqzxy neuqzxy deleted the feat/label-component-ignore-text-buf branch June 13, 2023 10:55
xile611 pushed a commit that referenced this pull request Jul 6, 2023
…-buf

Feat/label component ignore text buf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants