Merge pull request #1313 from VisActor/fix/mark-point-target-size

Fix/mark point target size
VisActor · Jul 23, 2024 · a050cd6 · a050cd6
2 parents 6769a97 + 9815854
commit a050cd6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/common/changes/@visactor/vrender-components/fix-mark-point-target-size_2024-07-20-21-17.json b/common/changes/@visactor/vrender-components/fix-mark-point-target-size_2024-07-20-21-17.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vrender-components",
+      "comment": "fix: markpoint target size compute error. fix@Visactor/VChart#2766",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vrender-components"
+}
diff --git a/packages/vrender-components/src/marker/point.ts b/packages/vrender-components/src/marker/point.ts
@@ -409,6 +409,7 @@ export class MarkPoint extends Marker<MarkPointAttrs, MarkPointAnimationType> {
         x: position.x,
         y: position.y,
         visible: targetItem.visible ?? false,
+        size: targetItem.size,
         ...targetItem.style
       });
       this._targetItem.states = merge({}, DEFAULT_STATES, this.attribute.state?.targetItem);
@@ -444,7 +445,7 @@ export class MarkPoint extends Marker<MarkPointAttrs, MarkPointAnimationType> {
       visible: targetItemvisible = false,
       size: targetSymbolSize
     } = targetSymbol;
-    const targetSize = targetItemvisible ? targetSymbolSize || (targetSymbolStyle.size ?? 10) : 0;
+    const targetSize = targetItemvisible ? targetSymbolStyle.size ?? targetSymbolSize ?? 20 : 0;
     const targetOffsetAngle = deltaXYToAngle(itemContentOffsetY, itemContentOffsetX);
     const newPosition: Point = {
       x: position.x + (targetSize / 2 + targetSymbolOffset) * Math.cos(targetOffsetAngle),