fix: fix the accuracy issue of number matching, closed #1488

VisActor · Oct 24, 2024 · 54f33f6 · 54f33f6
1 parent 2a51b68
commit 54f33f6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/common/changes/@visactor/vrender-core/fix-subview-check_2024-10-21-03-36.json b/common/changes/@visactor/vrender-core/fix-subview-check_2024-10-21-03-36.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vrender-core",
+      "comment": "fix: fix the accuracy issue of number matching, closed #1488",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vrender-core"
+}
diff --git a/packages/vrender-core/src/core/window.ts b/packages/vrender-core/src/core/window.ts
@@ -1,6 +1,6 @@
 import { inject, injectable } from '../common/inversify-lite';
 import type { IPointLike } from '@visactor/vutils';
-import { Matrix, type IBoundsLike, type IMatrix, IBounds, Point } from '@visactor/vutils';
+import { Matrix, type IBoundsLike, type IMatrix, IBounds, Point, isEqual, isNumberClose } from '@visactor/vutils';
 import { Generator } from '../common/generator';
 import type {
   ICanvas,
@@ -234,8 +234,8 @@ export class DefaultWindow implements IWindow {
     return !(
       viewBox.x1 === 0 &&
       viewBox.y1 === 0 &&
-      this.width === viewBox.width() &&
-      this.height === viewBox.height()
+      isNumberClose(this.width, viewBox.width()) &&
+      isNumberClose(this.height, viewBox.height())
     );
   }