Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative indexing in dex module. #1730

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Fix negative indexing in dex module. #1730

merged 3 commits into from
Jun 16, 2022

Commits on Jun 16, 2022

  1. Fix negative indexing in dex module. 

    When attempting to call dex_get_integer() or dex_get_string() with a negative
index we would eventually land in the assert() at
https://github.com/VirusTotal/yara/blob/master/libyara/object.c#L497 failing.
Instead of doing that let's check for negative values before going any further,
which will at least allow the module to continue processing.
    @wxsBSD
    wxsBSD committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    949aa5f View commit details
    Browse the repository at this point in the history

  2. YR_UNDEFINED is < 0 already. Simplify the logic when checking for neg… 

    …ative index.
    @wxsBSD
    wxsBSD committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    38af38f View commit details
    Browse the repository at this point in the history

  3. Revert "YR_UNDEFINED is < 0 already. Simplify the logic when checking… 

    … for negative index."

This reverts commit 38af38f.
    @wxsBSD
    wxsBSD committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    cf5bca7 View commit details
    Browse the repository at this point in the history