Magic tests fix #1714
Merged
Magic tests fix #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out different versions of libmagic return different file identification for the PE32 sample in magic tests. Relax this condition to the common part of the identification to make tests less reliant on the testing platform.
plusvic
approved these changes
May 28, 2022
BitsOfBinary
pushed a commit
to BitsOfBinary/yara
that referenced
this pull request
May 29, 2022
* test: Relax pe32 condition in magic tests Turns out different versions of libmagic return different file identification for the PE32 sample in magic tests. Relax this condition to the common part of the identification to make tests less reliant on the testing platform. * test: Relax macho condition in magic tests
plusvic
pushed a commit
that referenced
this pull request
Jun 30, 2022
* test: Relax pe32 condition in magic tests Turns out different versions of libmagic return different file identification for the PE32 sample in magic tests. Relax this condition to the common part of the identification to make tests less reliant on the testing platform. * test: Relax macho condition in magic tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test conditions for magic module. This change is necessary because different versions of libmagic return different identifications.
For example docker image
centos:7fails to passmake checktests. I extracted thePE32_FILEandMACHO_X86_FILEusing python into a file and usingfileidentified expected output.Additionally to the original issue there is also problem with the macho binary, this time not with
magic.type()butmagic.mime_type()which returns:vs. current arch linux:
λ file -i full.macho full.macho: application/x-mach-binary; charset=binaryMS-DOS executablewhich is common identification for both libmagic versionsmagic.mime_type()Fixes #1713