Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has_subClasses flag #43

Open
dosumis opened this issue Mar 7, 2023 · 5 comments
Open

Add has_subClasses flag #43

dosumis opened this issue Mar 7, 2023 · 5 comments
Assignees

Comments

@dosumis
Copy link
Member

dosumis commented Mar 7, 2023

Use case - driving query display

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>

CONSTRUCT {
	?x <http://n2o.neo/property/nodeLabel> "has_subClass" .
}
WHERE {
  ?y owl:subClassOf ?x . 
}
Robbie1977 added a commit that referenced this issue Mar 7, 2023
@dosumis
Copy link
Member Author

dosumis commented Mar 7, 2023

For this to work, we need pre-reasoning to happen before the SPARQL. This is not currently the case. SPARQL runs on the triplestore.

It would work if we ran SPARQL construct using ROBOT after this stage:
https://github.com/VirtualFlyBrain/vfb-pipeline-dumps/blob/vfb_pipeline/dumps.Makefile#L59]. I think this means that we need to either move all construct to work with derived files + ROBOT, or have just some of SPARQL run post-reasoning. These will need a different name scheme (right now, everything that starts with construct_ runs on the triple store.)

Also need to check whether product of construct_all.owl ends up in both Neo & SOLR (looks like it goes into SOLR via obographs.json goal.

CC @hkir-dev

@admclachlan admclachlan self-assigned this Mar 7, 2023
@hkir-dev
Copy link
Contributor

hkir-dev commented Mar 7, 2023

Neo4j2owl is processing these labels as well: https://github.com/VirtualFlyBrain/neo4j2owl/blob/migrate_neo4j_hk/src/main/java/ebi/spot/neo4j2owl/importer/N2OOntologyLoader.java#L381

I can start the implementation of ROBOT based construct files processing. I don't think it will cause any performance issues.

Ps: We should be careful about memory usage since ROBOT query is using jena afaik and reason is using owlapi. If we combine these functions there is a risk to use 2X memory. But it won't be a problem if we use separate processes to run these functions.

@dosumis
Copy link
Member Author

dosumis commented Mar 7, 2023

New step should run after reasoning but before merge.

@dosumis
Copy link
Member Author

dosumis commented Mar 7, 2023

Requires pipeline modification specified here: #48

@Robbie1977
Copy link
Contributor

#48 has now been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants