311 support shank orientation (#315)

* Added ShankOrientation support * Update setup-python * Version bump * CCW ShankOrientation * Autoformat code * Dependabot in workflows --------- Co-authored-by: kjy5 <[email protected]>
VirtualBrainLab · Feb 5, 2024 · 7d47997 · 7d47997
1 parent 9841f15
commit 7d47997
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -10,6 +10,6 @@ updates:
     schedule:
       interval: "weekly"
   - package-ecosystem: "github-actions" # See documentation for possible values
-    directory: ".github/" # Location of package manifests
+    directory: ".github/workflows" # Location of package manifests
     schedule:
       interval: "weekly"
diff --git a/.github/workflows/autoformat-and-lint.yml b/.github/workflows/autoformat-and-lint.yml
@@ -23,7 +23,7 @@ jobs:
           token: ${{ secrets.WORKFLOW_COMMIT }}
 
       - name: 🐍 Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: '3.12'
           cache: 'pip'

diff --git a/src/ephys_link/__about__.py b/src/ephys_link/__about__.py
@@ -1 +1 @@
-__version__ = "1.2.2"
+__version__ = "1.2.3"
diff --git a/src/ephys_link/platforms/new_scale_pathfinder_handler.py b/src/ephys_link/platforms/new_scale_pathfinder_handler.py
@@ -191,19 +191,15 @@ def _get_angles(self, manipulator_id: str) -> com.AngularOutputData:
             [
                 adjusted_polar if adjusted_polar > 0 else 360 + adjusted_polar,
                 manipulator_data["Pitch"],
-                manipulator_data["Roll"],
+                (360 - manipulator_data.get("ShankOrientation", 0)) % 360,
             ],
             "",
         )
 
     def _get_shank_count(self, manipulator_id: str) -> com.ShankCountOutputData:
         for probe in self.query_data()["ProbeArray"]:
             if probe["Id"] == manipulator_id:
-                if "ShankCount" in probe:
-                    return com.ShankCountOutputData(probe["ShankCount"], "")
-
-                # Default to 1.0 if shank count is not found
-                return com.ShankCountOutputData(1, "")
+                return com.ShankCountOutputData(probe.get("ShankCount", 1), "")
 
         return com.ShankCountOutputData(-1, "Unable to find manipulator")