- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add November 2024 Challenge to the Website #1286
feat: Add November 2024 Challenge to the Website #1286
Conversation
👷 Deploy Preview for virtual-coffee-io processing.
|
@danieltott, FYI. The mock data for the form still appears on the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Is there a reason you don't have hyperlinks set to open in a new tab? The only ones that do so are the hyperlink and button to the submission form.
I always set external links to open in a new tab so we don't navigate the user away from our site. It's a way of increasing retention and length of site visit.
If you don't have a specific reason for the way you set the hyperlinks, could you add target="_blank" rel="noreferrer"
to the rest of the external links on the page? Besides that, it looks good to go!
@danieltott I created a NaNoWriMo 2024 view in the Monthly Challenges Airtable DB. It's just waiting for you to hook it up in the codes -- I still don't know how to do that part. |
Since I learned, accessibility-wise, that we better refrain from opening new windows and tabs from a link if not necessary according to WCAG 2.0, I hold myself to add the But if you think we better add it here, let's add it. 👍🏼 |
Hmm... that's a good point though. My reasoning is from a marketing/SEO perspective, however, we do want to adhere to good A11y practices. I think your reasoning is good enough to leave it as it is, but now I'm curious... I'm going to post in Slack and possibly on Twitter to get some feedback. Let's see what kind of responses we get back and perhaps we can come to a conclusion from there that will guide us going forward. Does that sound good to you? |
@meg-gutshall sounds good to me. 👍 |
I agree with @adiati98 (and the WCAG) that opening new windows just to get users to stay longer is an anti-pattern. If a user wants to come back they know how 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked Issue
Closes #1285
Description
This PR adds November 2024 challenge (Blogging Challenge) to the website.
Live Preview
Challenge Homepage
https://deploy-preview-1286--virtual-coffee-io.netlify.app/monthlychallenges
Challenge Page
https://deploy-preview-1286--virtual-coffee-io.netlify.app/monthlychallenges/nov-2024
Methodology
Code of Conduct