Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

VP-1172: Fix behavior of quote request form #151

Merged
merged 1 commit into from
Jul 6, 2020
Merged

VP-1172: Fix behavior of quote request form #151

merged 1 commit into from
Jul 6, 2020

Conversation

ilyawzrd
Copy link
Contributor

@ilyawzrd ilyawzrd commented Jul 2, 2020

Fixed scenario of setting billing and shipping addresses, now shipping address is hidden when "Shipping address is same as billing address" is checked. Also fixed scenario when billing address is populated after checking "Shipping address is same as billing address".

quotegif

@ilyawzrd ilyawzrd requested review from t13ka and yecli July 2, 2020 16:21
@vc-ci
Copy link
Contributor

vc-ci commented Jul 2, 2020

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR quote-request.js#L78: Rename "countryRegion" as this name is already used in declaration at line 71. rule
  2. MAJOR quote-request.js#L147: "response" hides or potentially hides a variable declared in an outer scope at line 146. rule

@yecli yecli merged commit ea260d6 into dev Jul 6, 2020
@yecli yecli deleted the bug/VP-1172 branch July 8, 2020 05:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants