Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VR-3128] Add support for passive event listeners #2

Merged
merged 2 commits into from
Dec 4, 2017
Merged

[VR-3128] Add support for passive event listeners #2

merged 2 commits into from
Dec 4, 2017

Conversation

Mulder90
Copy link

No description provided.

@Mulder90 Mulder90 force-pushed the VR-3128-passive-event-listeners branch from a1db50c to 9255e66 Compare November 29, 2017 14:09
aberonni
aberonni reviewed Dec 1, 2017
View reviewed changes
Copy link

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether the default should be passive:true for all listeners.

@Mulder90 Mulder90 force-pushed the VR-3128-passive-event-listeners branch from 9255e66 to b32ecc1 Compare December 1, 2017 14:36
@Mulder90 Mulder90 force-pushed the VR-3128-passive-event-listeners branch from b32ecc1 to 1d0a75e Compare December 4, 2017 11:12
@aberonni aberonni merged commit 2e93f1a into master Dec 4, 2017
@aberonni aberonni deleted the VR-3128-passive-event-listeners branch December 4, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni left review comments

@canemacchina canemacchina Awaiting requested review from canemacchina

Assignees

@canemacchina canemacchina

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mulder90 @aberonni @canemacchina