Refactor the package #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Publishing package configuration is no longer requried if you're satisfied with the defaults - Adhere to PSR-4 autoloading standard - Define package dependencies better - Add simple PHPUnit tests - Rename Guide facade to Country facade for clarity - Add phpDoc comments for better code intel
Mulkave
reviewed
Mar 29, 2019
src/Guide.php
Outdated
| { | ||
| $countries = $this->config->get('countries'); | ||
|
|
||
| if (array_search(ucwords($name), $countries)) { |
There was a problem hiding this comment.
would this be better assigned to a variable and then returned? e.g.
$found = array_search(ucwords($name), $countries);
if ($found) {
return $found
} else {
...
}There was a problem hiding this comment.
@Mulkave Sure, I took it a bit further and also extracted the logic into scanStringNames and scanArrayNames methods, because it was hard to understand what's going when looking at this condition.
|
Also added package auto-discovery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are made in this PR: