add a path() function #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 19, 2014 19:02
the difference between those 2 functions is assets always starts from the public/ while asset takes a full path starting from the app/
to affect this commit 6a0ed63 changes
rename preparePathAndCallUrlGenerator to generateUrl and update this function parameter related to commit #6a0ed63b22c20e3117c4e35c8b2f35e8926b4ccf
rename testPreparePathThrowsExceptionWhenEmptyParameter to testUrlGeneratorThrowsException related to commit #6a0ed63b22c20e3117c4e35c8b2f35e8926b4ccf
|
re-factoring |
added 2 commits
September 22, 2014 16:52
related to commit #6a0ed63b22c20e3117c4e35c8b2f35e8926b4ccf
related to commit #6a0ed63b22c20e3117c4e35c8b2f35e8926b4ccf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a cdn::path() function to allow users upload files from the app dir
make cdn::asset() search for files in the public dir
update the documentation