Dead lettering support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisissa
reviewed
Jan 11, 2017
| * @param bool $passive | ||
| * @param bool $durable | ||
| * @param bool $autoDelete | ||
| * @param int $deliveryMode | ||
| */ | ||
| public function __construct(Connection $connection, $exchangeName, $exchangeType = 'fanout', $passive = false, $durable = true, $autoDelete = false, $deliveryMode = 2) | ||
| public function __construct(Connection $connection, $queueName, $exchangeName, $exchangeType = 'fanout', $bindingKeys = [null], $passive = false, $durable = true, $autoDelete = false, $deliveryMode = 2) |
There was a problem hiding this comment.
$bindingKeys = [null] better be empty array, and do the check later
| $deliveryMode = (int) $this->option('deliveryMode'); | ||
|
|
||
| // Dead Lettering | ||
| $deadLetterQueueName = ($qName = $this->option('deadLetterQueueName')) ? $qName : (($xName = $this->option('deadLetterExchangeName')) ? $xName : null); |
| */ | ||
| private function compileArguments($deadLetterExchangeName, $deadLetterRoutingKey, $messageTtl) | ||
| { | ||
| $this->arguments['x-dead-letter-exchange'] = ['S', $deadLetterExchangeName]; |
There was a problem hiding this comment.
add comment to explain the 'S' argument
| $this->Arguments['x-dead-letter-routing-key'] = ['S', $deadLetterRoutingKey]; | ||
| } | ||
|
|
||
| if($messageTtl) { |
|
As the implementation is currently, if a user intend to use dead lettering and a exception is thrown once the app exchange/queue are declared for what ever reason (e.g. config/params mismatch), the dlx queue and exchange will be created a priori. I am afraid this might lead to dangling queues and exchanges.
|
So that both the producer and consumer can take advantage of.
So we can get the producer/consumer exchange/queue declaration and other params
since these are specific to the consumer.
Figure out a way to give the producer access to these functionalities
And thus, setting up dead lettering as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6
resolves #7
resolves #8
resolves #9
resolves #10
resolves #13
resolves #14
resolves #16
resolves #17