Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to unblock https://github.com/nim-lang/Nim/pull/14869 #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timotheecour
Copy link

@timotheecour timotheecour commented Jul 1, 2020

/cc @Vindaar somehow your packages are my usual suspect PR blockers; that's actually a good thing because it's better to catch problems early on (and figure out good solutions) before a PR is merged rather than "in the wild". So thanks for breaking my PR's ;-)

before this PR:
nim-lang/Nim#14869 fails only because of this package, giving:

2020-07-01T10:34:35.1005100Z �[1m�[31mFAIL: �[36mhttps://github.com/Vindaar/ggplotnim C�[0m
2020-07-01T10:34:35.1006090Z �[1m�[36mTest "https://github.com/Vindaar/ggplotnim" in category "nimble-packages-1"�[0m
2020-07-01T10:34:35.1008480Z �[1m�[31mFailure: reBuildFailed�[0m
2020-07-01T10:34:35.1015110Z package test failed
2020-07-01T10:34:35.1015800Z $ nim c -d:noCairo -r tests/tests.nim
2020-07-01T10:34:35.1017100Z Hint: used config file '/Users/runner/runners/2.263.0/work/Nim/Nim/config/nim.cfg' [Conf]
2020-07-01T10:34:35.1017970Z Hint: used config file '/Users/runner/runners/2.263.0/work/Nim/Nim/config/config.nims' [Conf]
2020-07-01T10:34:35.1019110Z Hint: used config file '/Users/runner/runners/2.263.0/work/Nim/Nim/pkgstemp/ggplotnim/tests/config.nims' [Conf]
2020-07-01T10:34:35.1019690Z ...............................................
2020-07-01T10:34:35.1020690Z /Users/runner/.nimble/pkgs/ginger-0.2.5/ginger.nim(1358, 40) Error: expression 'updateScale(view, it)' has no type (or is ambiguous)
2020-07-01T10:34:35.1020890Z 

after this PR:
it works.

@Vindaar
Copy link
Owner

Vindaar commented Jul 10, 2020

somehow your packages are my usual suspect PR blockers; that's actually a good thing because it's better to catch problems early on (and figure out good solutions) before a PR is merged rather than "in the wild". So thanks for breaking my PR's ;-)

Haha, that is good to hear. I was starting to worry you might be annoyed by that.

I haven't merged this yet, because your View PR is still a draft and the discussion there seems to favor it as a nimble package. I think it'd be a great addition. I wonder if with nim-lang/RFCs#88 implemented the API of View could remain the same, so that the PR could be merged in the mean time without worry that I'd (hopefully quickly) become outdated? Well, here isn't the best place to discuss this of course.

Also there being no documentation yet on lent in the manual makes me a little hesitant to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants