Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHAR compactors #280

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Add PHAR compactors #280

merged 4 commits into from
Jul 20, 2024

Conversation

VincentLanglet
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a58ce7e) to head (75c175a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #280   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       718       718           
===========================================
  Files             64        64           
  Lines           2230      2230           
===========================================
  Hits            2230      2230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VincentLanglet VincentLanglet force-pushed the scopePhar branch 2 times, most recently from 4349293 to 2883c3b Compare July 20, 2024 20:42
@VincentLanglet VincentLanglet force-pushed the scopePhar branch 3 times, most recently from 030a9cf to e92d46c Compare July 20, 2024 21:00
@VincentLanglet VincentLanglet merged commit e5a32e1 into main Jul 20, 2024
18 checks passed
@VincentLanglet VincentLanglet deleted the scopePhar branch July 20, 2024 22:29
@llaville
Copy link
Contributor

@VincentLanglet Per my experience , I do not recommend to use the KevinGH\Box\Compactor\Php compactor, because it's difficult to found origin of an issue when you've a back trace raised by PHAR execution (file line are changed corresponding to original source code, because phpdoc blocks are stripped). Particular difficult to debug because we have no idea what dependencies are included into the PHAR artifact.
When the compression is enabled, the gain is very poor.

@VincentLanglet
Copy link
Owner Author

@VincentLanglet Per my experience , I do not recommend to use the KevinGH\Box\Compactor\Php compactor, because it's difficult to found origin of an issue when you've a back trace raised by PHAR execution (file line are changed corresponding to original source code, because phpdoc blocks are stripped). Particular difficult to debug because we have no idea what dependencies are included into the PHAR artifact. When the compression is enabled, the gain is very poor.

Hi,

I made tests and as soon as I use KevinGH\\Box\\Compactor\\PhpScoper it already change the lines. So using the PHP compactor as an extra doesn't add any extra-issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants