Add test (#269)

VincentLanglet · Jul 16, 2024 · 150694c · 150694c
1 parent af956d3
commit 150694c
Show file tree

Hide file tree

Showing 9 changed files with 47 additions and 24 deletions.
diff --git a/src/Console/Application.php b/src/Console/Application.php
@@ -12,34 +12,25 @@ final class Application extends BaseApplication
     public const APPLICATION_NAME = 'Twig-CS-Fixer';
     public const PACKAGE_NAME = 'vincentlanglet/twig-cs-fixer';
 
-    public function __construct()
+    public function __construct(string $name = self::APPLICATION_NAME, string $package = self::PACKAGE_NAME)
     {
-        parent::__construct(self::APPLICATION_NAME, $this->getPackageVersion());
+        parent::__construct($name, $this->getPackageVersion($package));
     }
 
-    private function getPackageVersion(): string
+    private function getPackageVersion(string $package): string
     {
         foreach (InstalledVersions::getAllRawData() as $installed) {
-            if (!isset($installed['versions'][self::PACKAGE_NAME])) {
+            if (!isset($installed['versions'][$package])) {
                 continue;
             }
 
-            $version = $installed['versions'][self::PACKAGE_NAME]['pretty_version']
-                ?? $installed['versions'][self::PACKAGE_NAME]['version']
-                ?? 'dev';
-
-            $aliases = $installed['versions'][self::PACKAGE_NAME]['aliases'] ?? [];
-
-            $reference = InstalledVersions::getReference(self::PACKAGE_NAME);
+            $version = $installed['versions'][$package]['pretty_version'] ?? 'dev';
+            $reference = $installed['versions'][$package]['reference'] ?? null;
             if (null === $reference) {
-                return $aliases[0] ?? $version;
+                return $version;
             }
 
-            return sprintf(
-                '%s@%s',
-                $aliases[0] ?? $version,
-                substr($reference, 0, 7)
-            );
+            return sprintf('%s@%s', $version, substr($reference, 0, 7));
         }
 
         return 'UNKNOWN';

diff --git a/src/Util/StringUtil.php b/src/Util/StringUtil.php
@@ -6,7 +6,7 @@
 
 use Symfony\Component\String\UnicodeString;
 
-class StringUtil
+final class StringUtil
 {
     /**
      * @see UnicodeString::camel()

diff --git a/tests/Console/ApplicationTest.php b/tests/Console/ApplicationTest.php
@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TwigCsFixer\Tests\Console;
+
+use PHPUnit\Framework\TestCase;
+use TwigCsFixer\Console\Application;
+
+final class ApplicationTest extends TestCase
+{
+    public function testVersion(): void
+    {
+        $app = new Application();
+        static::assertSame(Application::APPLICATION_NAME, $app->getName());
+        static::assertMatchesRegularExpression('/^dev-.+@.{7}$/', $app->getVersion());
+    }
+
+    public function testNotInstalledLib(): void
+    {
+        $app = new Application('Foo', 'foo');
+        static::assertSame('Foo', $app->getName());
+        static::assertSame('UNKNOWN', $app->getVersion());
+    }
+
+    public function testLibWithoutVersion(): void
+    {
+        $app = new Application('Psalm', 'psalm/psalm');
+        static::assertSame('Psalm', $app->getName());
+        static::assertSame('dev', $app->getVersion());
+    }
+}
diff --git a/tests/Rules/Node/ForbiddenBlock/ForbiddenBlockRuleTest.php b/tests/Rules/Node/ForbiddenBlock/ForbiddenBlockRuleTest.php
@@ -7,7 +7,7 @@
 use TwigCsFixer\Rules\Node\ForbiddenBlockRule;
 use TwigCsFixer\Tests\Rules\AbstractRuleTestCase;
 
-class ForbiddenBlockRuleTest extends AbstractRuleTestCase
+final class ForbiddenBlockRuleTest extends AbstractRuleTestCase
 {
     public function testConfiguration(): void
     {

diff --git a/tests/Rules/Node/ForbiddenFilter/ForbiddenFilterRuleTest.php b/tests/Rules/Node/ForbiddenFilter/ForbiddenFilterRuleTest.php
@@ -7,7 +7,7 @@
 use TwigCsFixer\Rules\Node\ForbiddenFilterRule;
 use TwigCsFixer\Tests\Rules\AbstractRuleTestCase;
 
-class ForbiddenFilterRuleTest extends AbstractRuleTestCase
+final class ForbiddenFilterRuleTest extends AbstractRuleTestCase
 {
     public function testConfiguration(): void
     {

diff --git a/tests/Rules/Node/ForbiddenFunction/ForbiddenFunctionRuleTest.php b/tests/Rules/Node/ForbiddenFunction/ForbiddenFunctionRuleTest.php
@@ -7,7 +7,7 @@
 use TwigCsFixer\Rules\Node\ForbiddenFunctionRule;
 use TwigCsFixer\Tests\Rules\AbstractRuleTestCase;
 
-class ForbiddenFunctionRuleTest extends AbstractRuleTestCase
+final class ForbiddenFunctionRuleTest extends AbstractRuleTestCase
 {
     public function testConfiguration(): void
     {

diff --git a/tests/Rules/String/HashQuote/HashQuoteRuleTest.php b/tests/Rules/String/HashQuote/HashQuoteRuleTest.php
@@ -7,7 +7,7 @@
 use TwigCsFixer\Rules\String\HashQuoteRule;
 use TwigCsFixer\Tests\Rules\AbstractRuleTestCase;
 
-class HashQuoteRuleTest extends AbstractRuleTestCase
+final class HashQuoteRuleTest extends AbstractRuleTestCase
 {
     public function testConfiguration(): void
     {

diff --git a/tests/Rules/String/SimpleQuote/SingleQuoteRuleTest.php b/tests/Rules/String/SimpleQuote/SingleQuoteRuleTest.php
@@ -7,7 +7,7 @@
 use TwigCsFixer\Rules\String\SingleQuoteRule;
 use TwigCsFixer\Tests\Rules\AbstractRuleTestCase;
 
-class SingleQuoteRuleTest extends AbstractRuleTestCase
+final class SingleQuoteRuleTest extends AbstractRuleTestCase
 {
     public function testConfiguration(): void
     {

diff --git a/tests/Util/StringUtilTest.php b/tests/Util/StringUtilTest.php
@@ -7,7 +7,7 @@
 use PHPUnit\Framework\TestCase;
 use TwigCsFixer\Util\StringUtil;
 
-class StringUtilTest extends TestCase
+final class StringUtilTest extends TestCase
 {
     /**
      * @dataProvider toSnakeCaseDataProvider